generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-74: support argo workflow #2976
Open
KunWuLuan
wants to merge
13
commits into
kubernetes-sigs:main
Choose a base branch
from
KunWuLuan:kep/kueue-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e6fb7b6
kep-74: support argo workflow
KunWuLuan baa5ecd
add kep
KunWuLuan 0fac846
update goals
KunWuLuan e6666be
complete the doc
KunWuLuan 933c14b
Update keps/74-support-argo-workflow/kep.yaml
KunWuLuan 2273de6
update doc
KunWuLuan 9486948
Update keps/74-support-argo-workflow/README.md
KunWuLuan 04379e1
Update keps/74-support-argo-workflow/README.md
KunWuLuan 43bd407
Update keps/74-support-argo-workflow/README.md
KunWuLuan a0668ff
Update keps/74-support-argo-workflow/README.md
KunWuLuan 012eabe
update toc
KunWuLuan 1ed89ab
update the design for workflow framework
KunWuLuan fc0837d
Merge branch 'kubernetes-sigs:main' into kep/kueue-workflow
KunWuLuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,132 @@ | ||||||||||
# KEP-74: Support Argo Workflow | ||||||||||
|
||||||||||
<!-- toc --> | ||||||||||
- [Summary](#summary) | ||||||||||
- [Motivation](#motivation) | ||||||||||
- [Goals](#goals) | ||||||||||
- [Non-Goals](#non-goals) | ||||||||||
- [Proposal](#proposal) | ||||||||||
- [User Stories](#user-stories) | ||||||||||
- [Design Details](#design-details) | ||||||||||
- [Additional Details](#additional-details) | ||||||||||
- [Test Plan](#test-plan) | ||||||||||
- [Unit Tests](#unit-tests) | ||||||||||
- [Integration tests](#integration-tests) | ||||||||||
- [Graduation Criteria](#graduation-criteria) | ||||||||||
- [Implementation History](#implementation-history) | ||||||||||
- [Drawbacks](#drawbacks) | ||||||||||
- [Alternatives](#alternatives) | ||||||||||
<!-- /toc --> | ||||||||||
|
||||||||||
## Summary | ||||||||||
|
||||||||||
|
||||||||||
|
||||||||||
## Motivation | ||||||||||
|
||||||||||
|
||||||||||
|
||||||||||
### Goals | ||||||||||
|
||||||||||
|
||||||||||
|
||||||||||
### Non-Goals | ||||||||||
|
||||||||||
|
||||||||||
|
||||||||||
## Proposal | ||||||||||
|
||||||||||
|
||||||||||
### User Stories | ||||||||||
|
||||||||||
|
||||||||||
|
||||||||||
## Design Details | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
|
||||||||||
|
||||||||||
## Additional Details | ||||||||||
|
||||||||||
### Test Plan | ||||||||||
|
||||||||||
<!-- | ||||||||||
**Note:** *Not required until targeted at a release.* | ||||||||||
The goal is to ensure that we don't accept enhancements with inadequate testing. | ||||||||||
|
||||||||||
All code is expected to have adequate tests (eventually with coverage | ||||||||||
expectations). Please adhere to the [Kubernetes testing guidelines][testing-guidelines] | ||||||||||
when drafting this test plan. | ||||||||||
|
||||||||||
[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md | ||||||||||
--> | ||||||||||
|
||||||||||
[x] I/we understand the owners of the involved components may require updates to | ||||||||||
existing tests to make this code solid enough prior to committing the changes necessary | ||||||||||
to implement this enhancement. | ||||||||||
|
||||||||||
#### Unit Tests | ||||||||||
|
||||||||||
<!-- | ||||||||||
In principle every added code should have complete unit test coverage, so providing | ||||||||||
the exact set of tests will not bring additional value. | ||||||||||
However, if complete unit test coverage is not possible, explain the reason of it | ||||||||||
together with explanation why this is acceptable. | ||||||||||
--> | ||||||||||
|
||||||||||
<!-- | ||||||||||
Additionally, try to enumerate the core package you will be touching | ||||||||||
to implement this enhancement and provide the current unit coverage for those | ||||||||||
in the form of: | ||||||||||
- <package>: <date> - <current test coverage> | ||||||||||
|
||||||||||
This can inform certain test coverage improvements that we want to do before | ||||||||||
extending the production code to implement this enhancement. | ||||||||||
--> | ||||||||||
The code will adhere to regular best practices for unit tests and coverage. | ||||||||||
|
||||||||||
|
||||||||||
|
||||||||||
#### Integration tests | ||||||||||
|
||||||||||
|
||||||||||
### Graduation Criteria | ||||||||||
<!-- | ||||||||||
|
||||||||||
Clearly define what it means for the feature to be implemented and | ||||||||||
considered stable. | ||||||||||
|
||||||||||
If the feature you are introducing has high complexity, consider adding graduation | ||||||||||
milestones with these graduation criteria: | ||||||||||
- [Maturity levels (`alpha`, `beta`, `stable`)][maturity-levels] | ||||||||||
- [Feature gate][feature gate] lifecycle | ||||||||||
- [Deprecation policy][deprecation-policy] | ||||||||||
|
||||||||||
[feature gate]: https://git.k8s.io/community/contributors/devel/sig-architecture/feature-gates.md | ||||||||||
[maturity-levels]: https://git.k8s.io/community/contributors/devel/sig-architecture/api_changes.md#alpha-beta-and-stable-versions | ||||||||||
[deprecation-policy]: https://kubernetes.io/docs/reference/using-api/deprecation-policy/ | ||||||||||
--> | ||||||||||
|
||||||||||
The feature starts at the beta level. | ||||||||||
|
||||||||||
|
||||||||||
## Implementation History | ||||||||||
|
||||||||||
<!-- | ||||||||||
Major milestones in the lifecycle of a KEP should be tracked in this section. | ||||||||||
Major milestones might include: | ||||||||||
- the `Summary` and `Motivation` sections being merged, signaling SIG acceptance | ||||||||||
- the `Proposal` section being merged, signaling agreement on a proposed design | ||||||||||
- the date implementation started | ||||||||||
- the first Kubernetes release where an initial version of the KEP was available | ||||||||||
- the version of Kubernetes where the KEP graduated to general availability | ||||||||||
- when the KEP was retired or superseded | ||||||||||
--> | ||||||||||
|
||||||||||
## Drawbacks | ||||||||||
|
||||||||||
<!-- | ||||||||||
Why should this KEP _not_ be implemented? | ||||||||||
--> | ||||||||||
|
||||||||||
|
||||||||||
## Alternatives |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
title: | ||
kep-number: 77 | ||
KunWuLuan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
authors: | ||
- "@kunwuluan" | ||
status: draft | ||
creation-date: 2024-09-04 | ||
reviewers: | ||
|
||
# The target maturity stage in the current dev cycle for this KEP. | ||
stage: alpha | ||
|
||
# The milestone at which this feature was, or is targeted to be, at each stage. | ||
milestone: | ||
alpha: "v0.9" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe: Kueue to directly implement workflow management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the non-goals. Thank you.