Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP: add flavorAssignmentStrategy to localQueue #376

Closed
wants to merge 1 commit into from
Closed

KEP: add flavorAssignmentStrategy to localQueue #376

wants to merge 1 commit into from

Conversation

kerthcet
Copy link
Contributor

@kerthcet kerthcet commented Sep 7, 2022

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind feature
/kind document

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #312

Special notes for your reviewer:

@kerthcet
Feat: add flavorAssignmentStrategy
45733b6 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

@kerthcet: The label(s) kind/document cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind feature
/kind document

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #312

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 7, 2022
@kerthcet kerthcet changed the title Feat: add flavorAssignmentStrategy to localQueue KEP: add flavorAssignmentStrategy to localQueue Sep 7, 2022
@kerthcet
Copy link
Contributor Author

kerthcet commented Sep 7, 2022

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 7, 2022
@alculquicondor
Copy link
Contributor

is this ready for review?

@kerthcet
Copy link
Contributor Author

kerthcet commented Sep 7, 2022

is this ready for review?

No, still a draft right now.

@alculquicondor
Copy link
Contributor

I'm going through open PRs now. Is this still WIP?

@kerthcet
Copy link
Contributor Author

I'm going through open PRs now. Is this still WIP?

Yes, still. But I'll focus on kueue in the following weeks.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2023
@kerthcet
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2023
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgirouard23, kerthcet
Once this PR has been reviewed and has the lgtm label, please assign denkensk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mwielgus
mwielgus reviewed Jul 20, 2023
View reviewed changes
docs/enhancements/312-add-flavorAssignmentStrategy-to-localQueue/README.md
minimum resources from other co-sharing clusterQueues to mitigate the disruptions once preemption is supported. Another case is when borrowing, we'd
like to keep the resource balance within each clusterQueue, or the corresponding pods will stuck in pending for exhausted of several special resources.

To achieve this, we'll introduce a new field `FlavorAssignmentStrategy` to `LocalQueue`, and we'll implement multiple strategies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why FlavorAssignmentStrategy should be placed in LocalQueue instead of ClusterQueue?

@alculquicondor
Copy link
Contributor

#810 and #849 seems to have covered this proposal. Can we close the PR?

@kerthcet
Copy link
Contributor Author

yes, close now.
/close

@k8s-ci-robot
Copy link
Contributor

@kerthcet: Closed this PR.

In response to this:

yes, close now.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus left review comments

@jgirouard23 jgirouard23 jgirouard23 approved these changes

@ahg-g ahg-g Awaiting requested review from ahg-g

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kerthcet @k8s-ci-robot @alculquicondor @k8s-triage-robot @tenzen-y @mwielgus @jgirouard23