-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install and Uninstall should use config/components/crd #395
Install and Uninstall should use config/components/crd #395
Conversation
Hi @kannon92. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks! Although I wonder if we should consider removing these 2 directives. They came with the scaffolding from kube-builder. But wdyt? /approve /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/hold cancel If necessary, we can remove the directives in a separate PR. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Running
make install
ormake uninstall
fails because it can't find the crd folder.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: