Add enhancements template and script for table of contents #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @ahg-g |
alculquicondor
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/unassign @ahg-g I better add some comments |
alculquicondor
force-pushed
the
update-toc
branch
from
cb92378
to
c38a3e0
Compare
alculquicondor
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @ahg-g |
alculquicondor
force-pushed
the
update-toc
branch
from
c38a3e0
to
5aa2e0b
Compare
kerthcet
reviewed
Sep 20, 2022
hack/update-toc.sh
Outdated
| | xargs mdtoc --inplace --max-depth=5 || ( | ||
| echo "Failed generating TOC. If this failed silently and you are on mac, try 'brew install grep'" | ||
| exit 1 | ||
| ) |
There was a problem hiding this comment.
Add a new line at the end? Similar to other files.
3 tasks
alculquicondor
force-pushed
the
update-toc
branch
3 times, most recently
from
b83c410
to
f91ca03
Compare
kerthcet
reviewed
Sep 20, 2022
| .PHONY: toc-verify | ||
| toc-verify: | ||
| ./hack/verify-toc.sh | ||
|
|
||
| .PHONY: vet |
There was a problem hiding this comment.
Should we also add update-toc to run the update-toc.sh.
Change-Id: I33920f2d9279260de8d16c3a9f3f8c698471c654
alculquicondor
force-pushed
the
update-toc
branch
from
f91ca03
to
b12bb93
Compare
|
Inspired by k/enhancements /lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add an enhancements template, a trimmed version from k/enhancements.
Also copy the scripts to update and verify the TOC
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: