Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeflow/spark-operator 'SparkApplication' integration #4032

Closed

Conversation

everpeace
Copy link

@everpeace everpeace commented Jan 21, 2025


What type of PR is this?

/kind feature

What this PR does / why we need it:

This adds kubeflow/spark-operator's SparkApplication integration in Kueue.

Technically, Kueue's Plain Pods integration can handle SparkApplication pods by putting kueue.x-k8s.io/* labels both in driver/executor pod template. However, SparkApplication integration can give simpler, better UX and deeper integrations for some Kueue's unique features: Topology Aware Scheduling, All-or-Nothing Scheduling, etc.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support kubeflow/spark-operator SparkApplication integration

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everpeace
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 21, 2025
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 6f7a6ca
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6797042eb784cb0008502f8a

Signed-off-by: Shingo Omura <everpeace@gmail.com>
@everpeace everpeace force-pushed the kubeflow-spark-operator branch from 9753382 to 799345a Compare January 21, 2025 14:03
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2025
@everpeace everpeace changed the title WIP: kubeflow/spark-operator's 'SparkApplication' integration without dynamicAllocation support(a.k.a. elastic job) WIP: kubeflow/spark-operator's 'SparkApplication' integration Jan 24, 2025
@everpeace everpeace force-pushed the kubeflow-spark-operator branch from 799345a to e79743d Compare January 24, 2025 03:58
@everpeace everpeace changed the title WIP: kubeflow/spark-operator's 'SparkApplication' integration WIP: kubeflow/spark-operator 'SparkApplication' integration Jan 24, 2025
that requires pod integration when dynamicAllocation was enabled

Signed-off-by: Shingo Omura <everpeace@gmail.com>
@everpeace everpeace force-pushed the kubeflow-spark-operator branch from e79743d to 6f7a6ca Compare January 27, 2025 03:57
@everpeace
Copy link
Author

everpeace commented Jan 28, 2025

I notice spark integration design was already proposed and approved in:
https://github.com/kubernetes-sigs/kueue/tree/main/keps/976-plain-pods#groups-of-pods-where-driver-generates-workers

This PR's design is far from the KEP. Thus, I'm closing this KEP.

@tenzen-y Thank you very much for this information.

@everpeace everpeace closed this Jan 28, 2025
@everpeace everpeace changed the title WIP: kubeflow/spark-operator 'SparkApplication' integration kubeflow/spark-operator 'SparkApplication' integration Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants