-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeflow/spark-operator 'SparkApplication' integration #4032
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: everpeace The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Signed-off-by: Shingo Omura <everpeace@gmail.com>
9753382
to
799345a
Compare
799345a
to
e79743d
Compare
that requires pod integration when dynamicAllocation was enabled Signed-off-by: Shingo Omura <everpeace@gmail.com>
e79743d
to
6f7a6ca
Compare
I notice spark integration design was already proposed and approved in: This PR's design is far from the KEP. Thus, I'm closing this KEP. @tenzen-y Thank you very much for this information. |
E2E Tests(As no custom job controllers implements E2E tests)What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds kubeflow/spark-operator's
SparkApplication
integration in Kueue.Technically, Kueue's Plain Pods integration can handle
SparkApplication
pods by puttingkueue.x-k8s.io/*
labels both in driver/executor pod template. However,SparkApplication
integration can give simpler, better UX and deeper integrations for some Kueue's unique features: Topology Aware Scheduling, All-or-Nothing Scheduling, etc.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?