Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAS: Support LeaderWorkerSet #4146

Merged
merged 1 commit into from
Feb 13, 2025
Merged

TAS: Support LeaderWorkerSet #4146

merged 1 commit into from
Feb 13, 2025

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Feb 4, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

TAS: Support LeaderWorkerSet

Which issue(s) this PR fixes:

Part of #3232

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 4, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit ff5824e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67adc95dd856900008b61a98

@mbobrovskyi mbobrovskyi force-pushed the feature/tas-lws branch 4 times, most recently from 07dfcf3 to 30c77e5 Compare February 12, 2025 15:00
@mbobrovskyi mbobrovskyi marked this pull request as ready for review February 13, 2025 07:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2025
@mbobrovskyi mbobrovskyi marked this pull request as draft February 13, 2025 07:32
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2025
@mbobrovskyi mbobrovskyi marked this pull request as ready for review February 13, 2025 07:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2025
@mimowo
Copy link
Contributor

mimowo commented Feb 13, 2025

@mbobrovskyi please drop the release note. LWS was not released yet. Single note is ok from the user-perspective imo.

@mimowo
Copy link
Contributor

mimowo commented Feb 13, 2025

Please also update site/content/en/docs/overview/_index.md as in https://github.com/kubernetes-sigs/kueue/pull/4174/files#diff-e33369adb6a19d194f0bf99f38f21407c3a309038e1520bb3f79ab66e9ae7358R56

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 13, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2025
@mbobrovskyi mbobrovskyi requested a review from mimowo February 13, 2025 09:35
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2025
mimowo
mimowo reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks, this is great start and I believe enough for 0.11.

This could be improved for rank-based ordering (either 0.11 or 0.12 would be fine) with the idea we already synced on: rank-based ordering across the PodSets of Leader and Workers within LWS group. I proposed to have a new "RingName" param insider the "TopologyRequest". If not specified then, as currently, rank-ordering happens within the PodSet. If specified, then the rank-based ordering happens accross PodSets with the same "RingName" . This requires extending the KEP with the proposal.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6a25a40561cdae9729bbbf3a0753f5f978a6a96b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit ef57fe7 into kubernetes-sigs:main Feb 13, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Feb 13, 2025
@mbobrovskyi mbobrovskyi deleted the feature/tas-lws branch February 13, 2025 11:03
dgrove-oss pushed a commit to dgrove-oss/kueue that referenced this pull request Feb 14, 2025
@mbobrovskyi @dgrove-oss
TAS: Support for LWS. (kubernetes-sigs#4146)
47993e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@gabesaba gabesaba Awaiting requested review from gabesaba

@PBundyra PBundyra Awaiting requested review from PBundyra

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@mbobrovskyi @k8s-ci-robot @mimowo