fix(plugins/plugin-client-common): double clicking on Commentary ente…

…rs edit mode, even for readOnly clients

part of #7977

plugins/plugin-client-common/src/components/Content/Commentary.tsx

@@ -15,7 +15,7 @@
  */
 
 import React from 'react'
-import { CommentaryResponse, REPL, i18n } from '@kui-shell/core'
+import { CommentaryResponse, REPL, i18n, isReadOnlyClient } from '@kui-shell/core'
 
 import Card from '../spi/Card'
 import Button from '../spi/Button'
@@ -169,7 +169,7 @@ export default class Commentary extends React.PureComponent<Props, State> {
 
   private card() {
     return (
-      <span className="kui--commentary-card" onDoubleClick={this._setEdit}>
+      <span className="kui--commentary-card" onDoubleClick={isReadOnlyClient() ? undefined : this._setEdit}>
         <Card
           {...this.props}
           data-is-editing={this.state.isEdit || undefined}

plugins/plugin-core-support/src/test/core-support/link-block.ts

@@ -37,7 +37,11 @@ describe('Link blocks', function(this: Common.ISuite) {
 
   it('paste the link to a commentary block, and expect the commentary block show the status of ls', async () => {
     try {
-      await CLI.command('#', this.app).then(ReplExpect.ok)
+      const res = await CLI.command('#', this.app).then(ReplExpect.ok)
+
+      await this.app.client
+        .$(`${Selectors.OUTPUT_N(res.count)} ${Selectors.COMMENTARY_EDITOR}`)
+        .then(_ => _.waitForDisplayed({ timeout: CLI.waitTimeout }))
 
       await this.app.client.execute(() => document.execCommand('paste'))