fix(plugins/plugin-client-common): breadcrumb fonts can be too large,…

… and double zoom Fixes #4519
kubernetes-sigs · May 11, 2020 · 2e1ce11 · 2e1ce11
1 parent 62272e6
commit 2e1ce11
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/plugins/plugin-client-common/src/components/spi/Breadcrumb/impl/Carbon.tsx b/plugins/plugin-client-common/src/components/spi/Breadcrumb/impl/Carbon.tsx
@@ -33,7 +33,7 @@ export default class CarbonBreadcrumb extends React.PureComponent<Props> {
           <BreadcrumbItem
             href="#"
             key={idx}
-            className={[_.className, _.deemphasize && 'kui--secondary-breadcrumb', 'zoomable'].filter(_ => _).join(' ')}
+            className={[_.className, _.deemphasize && 'kui--secondary-breadcrumb'].filter(_ => _).join(' ')}
             isCurrentPage={idx === currentPageIdx}
             onClick={_.command && (() => this.props.repl.pexec(_.command))}
           >

diff --git a/plugins/plugin-client-common/src/components/spi/Breadcrumb/impl/PatternFly.tsx b/plugins/plugin-client-common/src/components/spi/Breadcrumb/impl/PatternFly.tsx
@@ -35,8 +35,7 @@ export default class PatternflyBreadcrumb extends React.PureComponent<Props> {
             className={[
               _.className,
               _.deemphasize && 'kui--secondary-breadcrumb',
-              idx === currentPageIdx && 'kui--current-page-breadcrumb',
-              'zoomable'
+              idx === currentPageIdx && 'kui--current-page-breadcrumb'
             ]
               .filter(_ => _)
               .join(' ')}

diff --git a/plugins/plugin-client-common/web/css/static/sidecar-main.css b/plugins/plugin-client-common/web/css/static/sidecar-main.css
@@ -397,6 +397,7 @@
   display: flex;
   align-items: center;
   overflow-x: hidden;
+  font-size: 0.875em;
 
   .sidecar-bottom-stripe-button:first-child {
     margin-left: 0.5em;

diff --git a/plugins/plugin-client-common/web/scss/components/Breadcrumb/Carbon.scss b/plugins/plugin-client-common/web/scss/components/Breadcrumb/Carbon.scss
@@ -6,6 +6,7 @@ body[kui-theme-style] nav[aria-label='Breadcrumb'] {
 
   .bx--breadcrumb {
     display: flex;
+    font-size: unset;
     flex-wrap: nowrap;
     font-family: var(--font-sans-serif);
     padding: 0 1em;
@@ -30,7 +31,7 @@ body[kui-theme-style] nav[aria-label='Breadcrumb'] {
 
       .bx--link {
         font-size: inherit;
-        font-size: 1em;
+        font-size: unset;
         font-weight: normal;
         color: var(--color-base0C);
         overflow: unset;