Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropDown theming issues #4618

Closed
starpit opened this issue May 16, 2020 · 1 comment · Fixed by #4619 or #4621
Closed

DropDown theming issues #4618

starpit opened this issue May 16, 2020 · 1 comment · Fixed by #4619 or #4621

Comments

@starpit
Copy link
Contributor

starpit commented May 16, 2020

  1. in Carbon, the hover background color is not consistent
  2. in Carbon, dropdown retains focus after it is closed
  3. hover effect has no spacing relative to the input timestamp
starpit added a commit to starpit/kui that referenced this issue May 16, 2020
@starpit
fix(plugins/plugin-client-common): DropDown theme alignment issues
e6e0a75 
Fixes kubernetes-sigs#4618
@starpit starpit mentioned this issue May 16, 2020
Merged
7 tasks
starpit added a commit that referenced this issue May 16, 2020
@starpit
fix(plugins/plugin-client-common): DropDown theme alignment issues
ef75baf 
Fixes #4618
@starpit
Copy link
Contributor Author

starpit commented May 16, 2020

a few more:

  1. PatternFly shows focus outline on kebab
  2. Carbon's :after rule for its kebab isn't themed
  3. Carbon's background colors aren't correct when the dropdown is open

@starpit starpit reopened this May 16, 2020
starpit added a commit to starpit/kui that referenced this issue May 16, 2020
@starpit
fix(plugins/plugin-client-common): more DropDown theming fixes
2cd520d 
Fixes kubernetes-sigs#4618
@starpit starpit mentioned this issue May 16, 2020
Merged
7 tasks
starpit added a commit to starpit/kui that referenced this issue May 16, 2020
@starpit
fix(plugins/plugin-client-common): more DropDown theming fixes
0149e45 
Fixes kubernetes-sigs#4618
starpit added a commit that referenced this issue May 16, 2020
@starpit
fix(plugins/plugin-client-common): more DropDown theming fixes
7d874a6 
Fixes #4618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@starpit