Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first-time users may not see Themes widget #6528

Closed
starpit opened this issue Jan 11, 2021 · 1 comment · Fixed by #6529
Closed

first-time users may not see Themes widget #6528

starpit opened this issue Jan 11, 2021 · 1 comment · Fixed by #6529
Labels
kind/bug Categorizes issue or PR as related to a bug. SEV1 HIGHEST PRIORITY

Comments

@starpit
Copy link
Contributor

starpit commented Jan 11, 2021

Not sure why, yet, but when i remove the settings file, i don't see the widget until i switch themes. After that, it shows up (and continues to, across restarts)
@starpit starpit added the kind/bug Categorizes issue or PR as related to a bug. label Jan 11, 2021
@starpit
Copy link
Contributor Author

starpit commented Jan 11, 2021

ok, this was a bug in my bug fix #6520

it was all good, but the error handling/no theme choice yet case called switchTo(defaultTheme, true) where true means don’t save this choice

copy-paste bug!

starpit pushed a commit to starpit/kui that referenced this issue Jan 11, 2021
fix(packages/core): first-time users may not see Themes widget
7522d2b 
Fixes kubernetes-sigs#6528
This was referenced Jan 11, 2021
Merged
Closed
@starpit starpit added the SEV1 HIGHEST PRIORITY label Jan 11, 2021
starpit pushed a commit that referenced this issue Jan 11, 2021
@starpit
fix(packages/core): first-time users may not see Themes widget
12f62a4 
Fixes #6528
starpit pushed a commit to starpit/kui that referenced this issue Jan 11, 2021
@starpit
fix(packages/core): first-time users may not see Themes widget
d678830 
Fixes kubernetes-sigs#6528
starpit pushed a commit that referenced this issue Jan 11, 2021
@starpit
fix(packages/core): first-time users may not see Themes widget
08db4e0 
Fixes #6528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. SEV1 HIGHEST PRIORITY
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(packages/core): first-time users may not see Themes widget starpit/kui
1 participant
@starpit