Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XTermResponse renderer uses span for rows, should use div? #6530

Closed
starpit opened this issue Jan 11, 2021 · 1 comment · Fixed by #6534
Closed

XTermResponse renderer uses span for rows, should use div? #6530

starpit opened this issue Jan 11, 2021 · 1 comment · Fixed by #6534
Labels
kind/bug Categorizes issue or PR as related to a bug. SEV1 HIGHEST PRIORITY

Comments

@starpit
Copy link
Contributor

starpit commented Jan 11, 2021

If you echo a very long string, the two lines are displayed as one.
@starpit starpit added kind/bug Categorizes issue or PR as related to a bug. SEV1 HIGHEST PRIORITY labels Jan 11, 2021
@starpit
Copy link
Contributor Author

starpit commented Jan 11, 2021

The bug here is in squashRow in plugin-bash-like/src/pty/copy.ts. It wasn't properly handling the transition between the end of one row and the first cell in the next.

starpit added a commit to starpit/kui that referenced this issue Jan 11, 2021
@starpit
fix(plugins/plugin-bash-like): wide shell output may not properly lin…
029a5fd 
…e wrap

Fixes kubernetes-sigs#6530
@starpit starpit mentioned this issue Jan 11, 2021
Merged
7 tasks
starpit added a commit that referenced this issue Jan 11, 2021
@starpit
fix(plugins/plugin-bash-like): wide shell output may not properly lin…
18ab6a1 
…e wrap

Fixes #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. SEV1 HIGHEST PRIORITY
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugins/plugin-bash-like): wide shell output may not properly lin… starpit/kui
1 participant
@starpit