Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kui's git branch command fails if the underlying git command decides to paginate #6535

Closed
starpit opened this issue Jan 11, 2021 · 1 comment · Fixed by #6536 or #6541
Closed

kui's git branch command fails if the underlying git command decides to paginate #6535

starpit opened this issue Jan 11, 2021 · 1 comment · Fixed by #6536 or #6541

Comments

@starpit
Copy link
Contributor

starpit commented Jan 11, 2021

Kui's git branch command invokes the underlying git branch via PTY. By default, that underlying command will paginate the response. As a consequence, Kui's git branch command will hang, since the underlying git branch command is silently waiting for input from the user.

We should have Kui invoke the underlying command with --no-pager

starpit added a commit to starpit/kui that referenced this issue Jan 11, 2021
starpit added a commit that referenced this issue Jan 11, 2021
starpit added a commit to starpit/kui that referenced this issue Jan 12, 2021
@starpit
Copy link
Contributor Author

starpit commented Jan 12, 2021

the fix was incomplete, e.g. it may not have fixed the inBrowser use case

@starpit starpit reopened this Jan 12, 2021
myan9 added a commit to myan9/kui that referenced this issue Jan 12, 2021
starpit pushed a commit that referenced this issue Jan 12, 2021
starpit pushed a commit to starpit/kui that referenced this issue Jan 12, 2021
starpit added a commit that referenced this issue Jan 12, 2021
starpit pushed a commit that referenced this issue Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant