Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when there're 3 splits, clicking table cells in the first split fail #6937

Closed
myan9 opened this issue Feb 3, 2021 · 0 comments · Fixed by #6943
Closed

when there're 3 splits, clicking table cells in the first split fail #6937

myan9 opened this issue Feb 3, 2021 · 0 comments · Fixed by #6943
Assignees

Comments

@myan9
Copy link
Contributor

myan9 commented Feb 3, 2021

Regression from https://github.com/IBM/kui/pull/6933/files#diff-f71cdf353a6228309be37c9f7b272ed3a137420286cbf634edf116e8caabd24bL901.

Missed porting the || thisSplit part when onSplit failed at finding main split.

The PR failed to capture this error because at that time, clicking table in the first split of 3 splits would create the 4th split, which was later fixed by #6934.

myan9 added a commit to myan9/kui that referenced this issue Feb 3, 2021
myan9 added a commit to myan9/kui that referenced this issue Feb 3, 2021
starpit pushed a commit that referenced this issue Feb 3, 2021
starpit pushed a commit to starpit/kui that referenced this issue Feb 3, 2021
starpit pushed a commit to starpit/kui that referenced this issue Feb 3, 2021
starpit pushed a commit that referenced this issue Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant