Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeStages splits command with >> incorrectly #7413

Closed
myan9 opened this issue May 18, 2021 · 3 comments · Fixed by #7769
Closed

pipeStages splits command with >> incorrectly #7413

myan9 opened this issue May 18, 2021 · 3 comments · Fixed by #7769
Labels
kind/bug Categorizes issue or PR as related to a bug. packages/core

Comments

@myan9
Copy link
Contributor

myan9 commented May 18, 2021

For commands that have >>, splitIntoPipeStages splits the command as redirecting to a file with prefix '> '
Screen Shot 2021-05-18 at 1 07 16 PM

@myan9 myan9 changed the title FancyPipeline renders >> incorrectly pipeStages splits command with >> incorrectly May 18, 2021
@starpit starpit added kind/bug Categorizes issue or PR as related to a bug. packages/core labels May 18, 2021
@starpit
Copy link
Contributor

starpit commented May 18, 2021

It's not just >>, but also these (and other related) forms:

>
>>
>&
2>1

@starpit
Copy link
Contributor

starpit commented May 18, 2021

@myan9 suggests that at the very least, we can just not parse >> as a redirect in the pipe stage parser

@starpit
Copy link
Contributor

starpit commented Jul 6, 2021

I suggest we split this into two pieces: one is the parsing issue. Second, in repl/exec, we always use vfs fwrite even if the redirect is an append, e.g. >>. The latter will require some updates to the fwrite api, so I suggest we handle that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. packages/core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants