Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateChecker does not render the changelog as markdown #7497

Closed
starpit opened this issue May 30, 2021 · 1 comment · Fixed by #7498
Closed

UpdateChecker does not render the changelog as markdown #7497

starpit opened this issue May 30, 2021 · 1 comment · Fixed by #7498
Assignees
@starpit
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@starpit
Copy link
Contributor

starpit commented May 30, 2021

our UpdateChecker renders links as shown, which is not as expected:

Screen Shot 2021-05-30 at 8 57 36 AM
@starpit starpit added the kind/bug Categorizes issue or PR as related to a bug. label May 30, 2021
@starpit
Copy link
Contributor Author

starpit commented May 30, 2021

Hmm, it's worse than that. Headers, etc. Nothing is rendering correctly. I think this is a regression from #7446

We no longer need to set the contentType to text/html

@starpit starpit changed the title Markdown does not seem to render liniks properly UpdateChecker does not render the changelog as markdown May 30, 2021
starpit added a commit to starpit/kui that referenced this issue May 30, 2021
@starpit
fix(plugins/plugin-electron-components): UpdateChecker does not rende…
b056025 
…r the changelog as markdown

Fixes kubernetes-sigs#7497
@starpit starpit mentioned this issue May 30, 2021
Merged
7 tasks
starpit added a commit to starpit/kui that referenced this issue May 30, 2021
@starpit
fix(plugins/plugin-electron-components): UpdateChecker does not rende…
25fc539 
…r the changelog as markdown

part of kubernetes-sigs#7497
@starpit starpit self-assigned this May 30, 2021
k8s-ci-robot pushed a commit that referenced this issue Jun 1, 2021
@starpit @k8s-ci-robot
fix(plugins/plugin-electron-components): UpdateChecker does not rende…
60d744b 
…r the changelog as markdown

part of #7497
starpit added a commit to starpit/kui that referenced this issue Jun 1, 2021
@starpit
fix(plugins/plugin-electron-components): UpdateChecker does not rende…
fad3318 
…r the changelog as markdown

part of kubernetes-sigs#7497
k8s-ci-robot pushed a commit that referenced this issue Jun 1, 2021
@starpit @k8s-ci-robot
fix(plugins/plugin-electron-components): UpdateChecker does not rende…
d27ab68 
…r the changelog as markdown

part of #7497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@starpit starpit

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugins/plugin-electron-components): UpdateChecker does not rende… starpit/kui
1 participant
@starpit