Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fullscreen pty apps like vi are a bit too tall #7598

Closed
starpit opened this issue Jun 9, 2021 · 0 comments · Fixed by #7599
Closed

fullscreen pty apps like vi are a bit too tall #7598

starpit opened this issue Jun 9, 2021 · 0 comments · Fixed by #7599
Labels
kind/flake Categorizes issue or PR as related to a flaky test.

Comments

@starpit
Copy link
Contributor

starpit commented Jun 9, 2021 •
edited
Loading

Another minor regression from SplitHeader. getSize() uses the scrollback for sizing, but now the padding is on the enclosed scrollback-block-list element. As a result, when you use vi, Kui scrolls a bit, vertically.
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
@starpit
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
bdf9e20 
…bit too tall

part of kubernetes-sigs#7598
@starpit starpit mentioned this issue Jun 9, 2021
Merged
7 tasks
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
@starpit
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
7da9adf 
…bit too tall

part of kubernetes-sigs#7598
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
@starpit
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
6593c50 
…bit too tall

part of kubernetes-sigs#7598
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
@starpit
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
97be7bb 
…bit too tall

part of kubernetes-sigs#7598
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
@starpit
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
0b74d30 
…bit too tall

part of kubernetes-sigs#7598
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
@starpit
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
8ab63da 
…bit too tall

part of kubernetes-sigs#7598
@starpit starpit added the kind/flake Categorizes issue or PR as related to a flaky test. label Jun 9, 2021
k8s-ci-robot pushed a commit that referenced this issue Jun 9, 2021
@starpit @k8s-ci-robot
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
48fe911 
…bit too tall

part of #7598
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
@starpit
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
5e723e6 
…bit too tall

part of kubernetes-sigs#7598
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
@starpit
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
32bb91e 
…bit too tall

part of kubernetes-sigs#7598
k8s-ci-robot pushed a commit that referenced this issue Jun 10, 2021
@starpit @k8s-ci-robot
fix(plugins/plugin-client-common): fullscreen pty apps like vi are a …
b65e507 
…bit too tall

part of #7598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/flake Categorizes issue or PR as related to a flaky test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugins/plugin-client-common): fullscreen pty apps like vi are a … starpit/kui
1 participant
@starpit