Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctrl+c then clear results in wrong command being executed #6986

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Feb 8, 2021

Fixes #6979

Description of what you did:

My PR is a:

  • πŸ’₯ Breaking change
  • πŸ› Bug fix
  • πŸ’… Enhancement
  • πŸš€ New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #6986 (07c40b6) into master (5fecfaa) will decrease coverage by 2.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6986      +/-   ##
==========================================
- Coverage   59.99%   57.36%   -2.63%     
==========================================
  Files          86       86              
  Lines        2702     2702              
  Branches      677      677              
==========================================
- Hits         1621     1550      -71     
- Misses        830      883      +53     
- Partials      251      269      +18     
Impacted Files Coverage Ξ”
packages/core/src/core/symbol-table.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/core/src/webapp/util/time.ts 5.12% <0.00%> (-43.59%) ⬇️
packages/core/src/repl/tab-completion.ts 53.33% <0.00%> (-26.67%) ⬇️
...ackages/core/src/webapp/bootstrap/init-electron.ts 35.29% <0.00%> (-17.65%) ⬇️
packages/core/src/models/mmr/content-types.ts 65.00% <0.00%> (-15.00%) ⬇️
packages/core/src/repl/exec.ts 65.80% <0.00%> (-8.30%) ⬇️
packages/core/src/repl/split.ts 80.00% <0.00%> (-5.27%) ⬇️
packages/core/src/webapp/queueing.ts 65.00% <0.00%> (-5.00%) ⬇️
packages/core/src/models/entity.ts 68.18% <0.00%> (-4.55%) ⬇️
packages/core/src/core/command-tree.ts 61.16% <0.00%> (-4.47%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 5fecfaa...07c40b6. Read the comment docs.

@starpit starpit merged commit b153110 into kubernetes-sigs:master Feb 8, 2021
@starpit starpit deleted the fix-6979 branch February 8, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ls (not enter), ctrl+c, clear screen, pwd -> ls is executed!
1 participant