Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins/plugin-kubectl): kubectl watchers stop receiving push notifications when context is changed #7748

Merged
merged 1 commit into from
Jun 30, 2021
Merged

fix(plugins/plugin-kubectl): kubectl watchers stop receiving push notifications when context is changed #7748

merged 1 commit into from
Jun 30, 2021

Conversation

myan9
Copy link
Contributor

@myan9 myan9 commented Jun 30, 2021 •
edited
Loading

Fixes #7747

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@myan9 myan9 requested a review from starpit as a code owner June 30, 2021 19:25
@k8s-ci-robot k8s-ci-robot requested a review from mark-nc June 30, 2021 19:25
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: myan9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2021
@myan9 myan9 changed the title fix(plugins/plugin-kubectl): kubectl watchers stop receiving push not… fix(plugins/plugin-kubectl): kubectl watchers stop receiving push notifications when context is changed Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 30, 2021
@starpit
Copy link
Contributor

starpit commented Jun 30, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0050a62 into kubernetes-sigs:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starpit starpit Awaiting requested review from starpit starpit is a code owner

@mark-nc mark-nc Awaiting requested review from mark-nc

Assignees

@starpit starpit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubectl watchers stopped receiving push notifications when context is changed
3 participants
@myan9 @k8s-ci-robot @starpit