Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins/plugin-kubectl): kubectl create ns failures do not display as errors in Kui #7756

Merged
merged 1 commit into from
Jul 1, 2021
Merged

fix(plugins/plugin-kubectl): kubectl create ns failures do not display as errors in Kui #7756

merged 1 commit into from
Jul 1, 2021

Conversation

myan9
Copy link
Contributor

@myan9 myan9 commented Jul 1, 2021 •
edited
Loading

Fixes #7755

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@myan9 myan9 requested a review from starpit as a code owner July 1, 2021 14:43
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2021
@k8s-ci-robot k8s-ci-robot requested a review from mark-nc July 1, 2021 14:43
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: myan9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2021
@myan9 myan9 changed the title fix: kubectl create ns failures do not display as errors in Kui fix(plugins/plugin-kubectl): kubectl create ns failures do not display as errors in Kui Jul 1, 2021
@starpit
Copy link
Contributor

starpit commented Jul 1, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit efd0db0 into kubernetes-sigs:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starpit starpit Awaiting requested review from starpit starpit is a code owner

@mark-nc mark-nc Awaiting requested review from mark-nc

Assignees

@starpit starpit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. pending/10_3_x size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubectl create ns failures do not display as errors in Kui (cosmetic)
3 participants
@myan9 @k8s-ci-robot @starpit