Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated functionalities to search bar which solves #7881 and #7490 #7883

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

mra-ruiz
Copy link
Contributor

@mra-ruiz mra-ruiz commented Aug 20, 2021

Fixes #7881
Fixes #7490
Added feature to navigate through all search matches and added corresponding tests.
searchBarNavigation

@mra-ruiz mra-ruiz requested a review from starpit as a code owner August 20, 2021 15:57
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 20, 2021
@k8s-ci-robot k8s-ci-robot requested a review from mark-nc August 20, 2021 15:57
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 20, 2021
@mra-ruiz
Copy link
Contributor Author

/assign @starpit

@starpit
Copy link
Contributor

starpit commented Aug 20, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mra-ruiz, starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit e0502c3 into kubernetes-sigs:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigable options for Kui Search Bar find-in-page stripe doesn't have much contrast
3 participants