Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-kubectl): Adding logs tab to some Kubernetes resources #7984

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

mra-ruiz
Copy link
Contributor

@mra-ruiz mra-ruiz commented Sep 14, 2021

Fixes #5456

My PR is a:
☐ πŸ’… Enhancement

Please confirm that your PR fulfills these requirements
☐ Multiple commits are squashed into one commit.
☐ The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
☐ All npm dependencies are pinned.

@mra-ruiz mra-ruiz requested a review from starpit as a code owner September 14, 2021 14:13
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2021
@mra-ruiz
Copy link
Contributor Author

/assign @starpit

@mra-ruiz mra-ruiz changed the title Adding logs tab to deployments, pods, and replicasets solving issue #… Adding logs tab to resources Fixing issue #5456 Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 14, 2021
@mra-ruiz mra-ruiz changed the title Adding logs tab to resources Fixing issue #5456 Adding logs tab to resources Sep 14, 2021
@mra-ruiz mra-ruiz changed the title Adding logs tab to resources fix(plugins/plugin-kubectl): Adding logs tab to some Kubernetes resources Sep 14, 2021
@starpit
Copy link
Contributor

starpit commented Sep 14, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@starpit
Copy link
Contributor

starpit commented Sep 14, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@starpit
Copy link
Contributor

starpit commented Sep 14, 2021

/remove-lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@starpit
Copy link
Contributor

starpit commented Sep 14, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mra-ruiz, starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 85bc6a6 into kubernetes-sigs:master Sep 14, 2021
@mra-ruiz mra-ruiz deleted the logs-tab branch September 14, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Deployments should offer a Logs tab
3 participants