Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: second-instance additionalData may be null #9352

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Apr 20, 2023

Description of what you did:

This works around an issue where the additionalData parameter is null when using "popup window" mode. Since it is null, env vars, etc. from the second instance will not be transmitted to the first. But for now, we need to fix the bad behavior where one cannot even open a second window.

Fixes #9351

Required Items

  • Your PR consists of a single commit (i.e. squash your commits)
  • Your commit and PR title starts with one of fix: | test: | chore: | doc:, to indicate the nature of the fix (see Conventional Commits)

Optional Items

  • 💥 This PR involves a breaking change. If so, include "BREAKING CHANGE: ...why..." in the commit and PR message.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mark-nc and myan9 April 20, 2023 13:45
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2023
@starpit starpit merged commit e508a85 into kubernetes-sigs:master Apr 20, 2023
@starpit starpit deleted the second-null branch April 20, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError exception after kubectl kui if kui window is already open
2 participants