fix: second-instance additionalData may be null #9352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
This works around an issue where the
additionalData
parameter isnull
when using "popup window" mode. Since it is null, env vars, etc. from the second instance will not be transmitted to the first. But for now, we need to fix the bad behavior where one cannot even open a second window.Fixes #9351
Required Items
fix:
|test:
|chore:
|doc:
, to indicate the nature of the fix (see Conventional Commits)Optional Items