Skip to content

Commit

Permalink
fix failed tests are depends on external container images
Browse files Browse the repository at this point in the history
  • Loading branch information
koba1t committed Sep 13, 2023
1 parent b8704b6 commit 508ba30
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions api/krusty/fnplugin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -504,8 +504,7 @@ func skipIfNoDocker(t *testing.T) {
}

func TestFnContainerGenerator(t *testing.T) {
t.Skip("armarchitecture")
//https://docs.docker.com/engine/reference/commandline/build/#git-repositories
t.Skip("it may failed by arm architecture")
skipIfNoDocker(t)
th := kusttest_test.MakeHarness(t)
o := th.MakeOptionsPluginsEnabled()
Expand Down Expand Up @@ -613,6 +612,7 @@ metadata:

func TestFnContainerTransformerWithConfig(t *testing.T) {
skipIfNoDocker(t)
//https://docs.docker.com/engine/reference/commandline/build/#git-repositories
build := exec.Command("docker", "build", "https://github.com/GoogleContainerTools/kpt-functions-sdk.git#go-sdk-v0.0.1:ts/hello-world",
"-f", "build/label_namespace.Dockerfile",
"-t", "gcr.io/kpt-functions/label-namespace:go-sdk-v0.0.1",
Expand Down

0 comments on commit 508ba30

Please sign in to comment.