kustomize edit add replacement

kustomize/commands/edit/add/addreplacement.go

@@ -18,6 +18,8 @@ type addReplacementOptions struct {
 
 func newCmdAddReplacement(fSys filesys.FileSystem) *cobra.Command {
 	var o addReplacementOptions
+	o.Replacement.Source = &types.SourceSelector{}
+	o.Replacement.Targets = append(o.Replacement.Targets, &types.TargetSelector{})
 	cmd := &cobra.Command{
 		Use:   "replacement",
 		Short: "add an item to replacement field",
@@ -59,14 +61,19 @@ func (o *addReplacementOptions) RunAddReplacement(fSys filesys.FileSystem) error
 		return err
 	}
 
+	if o.Replacement.Targets != nil {
+		o.Replacement.Targets = nil
+	}
+	if o.Replacement.Source != nil {
+		o.Replacement.Source = nil
+	}
+
 	for _, r := range m.Replacements {
-		if r.Replacement.Source != nil || r.Replacement.Targets != nil {
-			if r.Path == o.Replacement.Path {
-				log.Printf("replacement %#v already in kustomization file", r)
-				return errors.New("already in kust")
-			}
+		if len(r.Path) > 0 && r.Path == o.Replacement.Path {
+			log.Printf("replacement %#v already in kustomization file", r)
+			return errors.New("already in kust")
 		}
-		m.Replacements = append(m.Replacements, r)
 	}
+	m.Replacements = append(m.Replacements, o.Replacement)
 	return mf.Write(m)
 }