Merge pull request #4791 from caproven/fix-4790

Performance fix for fetching previous resource IDs
kubernetes-sigs · Sep 12, 2022 · ce18530 · ce18530
2 parents 6c587c9 + ca71736
commit ce18530
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/api/internal/utils/makeResIds.go b/api/internal/utils/makeResIds.go
@@ -49,12 +49,12 @@ func PrevIds(n *yaml.RNode) ([]resid.ResId, error) {
 				"number of previous namespaces, " +
 				"number of previous kinds not equal")
 	}
+	meta, err := n.GetMeta()
+	if err != nil {
+		return nil, fmt.Errorf("cannot parse resource metadata: %w", err)
+	}
+	group, version := resid.ParseGroupVersion(meta.APIVersion)
 	for i := range names {
-		meta, err := n.GetMeta()
-		if err != nil {
-			return nil, err
-		}
-		group, version := resid.ParseGroupVersion(meta.APIVersion)
 		gvk := resid.Gvk{
 			Group:   group,
 			Version: version,