Skip to content

Commit

Permalink
Merge pull request #5506 from cloud-native-team/master
Browse files Browse the repository at this point in the history
fix some comments
  • Loading branch information
k8s-ci-robot committed Jun 18, 2024
2 parents b02d02a + d56e1d0 commit e3a7615
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion api/internal/target/kusttarget.go
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ func (kt *KustTarget) accumulateResources(
return ra, nil
}

// accumulateResources fills the given resourceAccumulator
// accumulateComponents fills the given resourceAccumulator
// with resources read from the given list of paths.
func (kt *KustTarget) accumulateComponents(
ra *accumulator.ResAccumulator, paths []string) (*accumulator.ResAccumulator, error) {
Expand Down
2 changes: 1 addition & 1 deletion cmd/config/internal/commands/run-fns.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
"sigs.k8s.io/kustomize/cmd/config/internal/generateddocs/commands"
)

// GetCatRunner returns a RunFnRunner.
// GetRunFnRunner returns a RunFnRunner.
func GetRunFnRunner(name string) *RunFnRunner {
r := &RunFnRunner{}
c := &cobra.Command{
Expand Down
2 changes: 1 addition & 1 deletion cmd/config/internal/inpututil/inpututil.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func MapInputsE(inputs []*yaml.RNode, fn MapInputsEFn) error {

type MapInputsFn func(*yaml.RNode, yaml.ResourceMeta) ([]*yaml.RNode, error)

// runs the function against each input Resource, providing the parsed metadata
// runs the function against each input Resource, providing the parsed metadata
func MapInputs(inputs []*yaml.RNode, fn MapInputsFn) ([]*yaml.RNode, error) {
var outputs []*yaml.RNode
for i := range inputs {
Expand Down
2 changes: 1 addition & 1 deletion kustomize/commands/edit/remove/removemetadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ type removeMetadataOptions struct {
kind kindOfAdd
}

// newCmdRemoveLabel removes one or more commonAnnotations from the kustomization file.
// newCmdRemoveAnnotation removes one or more commonAnnotations from the kustomization file.
func newCmdRemoveAnnotation(fSys filesys.FileSystem, v func([]string) error) *cobra.Command {
var o removeMetadataOptions
o.kind = label
Expand Down
2 changes: 1 addition & 1 deletion kyaml/fn/framework/selector.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func initMatcherTemplates(matchers []ResourceMatcher, data interface{}) error {

var _ ResourceTemplateMatcher = &OrSelector{}

// OrSelector is a kio.Filter that selects resources when that match all of its embedded
// AndSelector is a kio.Filter that selects resources when that match all of its embedded
// matchers.
type AndSelector struct {
// Matchers is the list of ResourceMatchers to try on the input resources.
Expand Down
2 changes: 1 addition & 1 deletion kyaml/fn/runtime/container/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ func (c *Filter) setupExec() error {
return nil
}

// getArgs returns the command + args to run to spawn the container
// getCommand returns the command + args to run to spawn the container
func (c *Filter) getCommand() (string, []string) {
network := runtimeutil.NetworkNameNone
if c.ContainerSpec.Network {
Expand Down
2 changes: 1 addition & 1 deletion kyaml/kio/ignorefilesmatcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func (i *ignoreFilesMatcher) matchFile(path string) bool {
return i.matchers[len(i.matchers)-1].matcher.Match(path, false)
}

// matchFile checks whether the directory given by the provided path matches
// matchDir checks whether the directory given by the provided path matches
// any of the patterns in the .krmignore file for the package.
func (i *ignoreFilesMatcher) matchDir(path string) bool {
if len(i.matchers) == 0 {
Expand Down
2 changes: 1 addition & 1 deletion kyaml/openapi/kustomizationapi/swagger.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion kyaml/openapi/openapi.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ type ResourceSchema struct {
Schema *spec.Schema
}

// IsEmpty returns true if the ResourceSchema is empty
// IsMissingOrNull returns true if the ResourceSchema is missing or null
func (rs *ResourceSchema) IsMissingOrNull() bool {
if rs == nil || rs.Schema == nil {
return true
Expand Down
2 changes: 1 addition & 1 deletion kyaml/yaml/alias.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const (
BareSeqNodeWrappingKey = "bareSeqNodeWrappingKey"
)

// SeqIndentType holds the indentation style for sequence nodes
// SequenceIndentStyle holds the indentation style for sequence nodes
type SequenceIndentStyle string

// EncoderOptions are options that can be used to configure the encoder,
Expand Down

0 comments on commit e3a7615

Please sign in to comment.