Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the --no-verify flag to kustomize localize #5276

Closed
1 of 2 tasks
annasong20 opened this issue Aug 18, 2023 · 10 comments
Closed
1 of 2 tasks

Add the --no-verify flag to kustomize localize #5276

annasong20 opened this issue Aug 18, 2023 · 10 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@annasong20
Copy link
Contributor

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

Currently, the kustomize localize command does not give users the option to automatically run kustomize build to verify the localized copy before command return. This feature is documented in the command's KEP.

We would like to give users the option to specify the --no-verify flag for kustomize localize. When not specified, kustomize localize should run kustomize build on both the source Kustomization and localized copy and compare their output. When specified, the command should only localize, without running kustomize build.

Why is this needed?

This feature is needed to graduate kustomize localize to beta, as stated in the KEP.

Can you accomplish the motivating task without this feature, and if so, how?

It was agreed upon in the KEP that this feature would be a nice convenience to users.

What other solutions have you considered?

The localization works without this feature, but this helps users avoid the need to run kustomize localize, then kustomize build themselves to check.

Anything else we should know?

No response

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@annasong20 annasong20 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 18, 2023
@annasong20
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 18, 2023
@rayandas
Copy link
Member

/assign

@rayandas
Copy link
Member

Apologise for my recent inactivity, as I had to attend to some personal matters over the past couple of weeks. I'm now back and will continuing the implementation from where I left off last time.

@natasha41575
Copy link
Contributor

@rayandas Since there hasn't been activity in almost 3 months, I will unassign this issue and move it back to TODO so that someone else can work on it. If you are still interested in working on this issue, please feel free to open up a draft PR so that we can see the current progress. Thanks!

/unassign

@ncapps
Copy link
Contributor

ncapps commented Dec 3, 2023

/assign

@ncapps
Copy link
Contributor

ncapps commented Feb 1, 2024

I haven't had time to make meaningful progress on this issue. I am unassigning myself in case someone else would like to pick it up.

/unassign

@ncapps ncapps moved this from In Progress to Todo in Kustomize Commands outside of `build` Feb 1, 2024
@sanaasy
Copy link
Contributor

sanaasy commented Feb 1, 2024

/assign

@sanaasy
Copy link
Contributor

sanaasy commented Jun 12, 2024

this issue has been completed!

@stormqueen1990
Copy link
Member

This has been done as part of #5544.

/close

@k8s-ci-robot
Copy link
Contributor

@stormqueen1990: Closing this issue.

In response to this:

This has been done as part of #5544.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Development

Successfully merging a pull request may close this issue.

7 participants