-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the --no-verify flag to kustomize localize
#5276
Comments
/triage accepted |
/assign |
Apologise for my recent inactivity, as I had to attend to some personal matters over the past couple of weeks. I'm now back and will continuing the implementation from where I left off last time. |
@rayandas Since there hasn't been activity in almost 3 months, I will unassign this issue and move it back to TODO so that someone else can work on it. If you are still interested in working on this issue, please feel free to open up a draft PR so that we can see the current progress. Thanks! /unassign |
/assign |
I haven't had time to make meaningful progress on this issue. I am unassigning myself in case someone else would like to pick it up. /unassign |
/assign |
this issue has been completed! |
This has been done as part of #5544. /close |
@stormqueen1990: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Eschewed features
What would you like to have added?
Currently, the
kustomize localize
command does not give users the option to automatically runkustomize build
to verify the localized copy before command return. This feature is documented in the command's KEP.We would like to give users the option to specify the
--no-verify
flag forkustomize localize
. When not specified,kustomize localize
should runkustomize build
on both the source Kustomization and localized copy and compare their output. When specified, the command should only localize, without runningkustomize build
.Why is this needed?
This feature is needed to graduate
kustomize localize
to beta, as stated in the KEP.Can you accomplish the motivating task without this feature, and if so, how?
It was agreed upon in the KEP that this feature would be a nice convenience to users.
What other solutions have you considered?
The localization works without this feature, but this helps users avoid the need to run
kustomize localize
, thenkustomize build
themselves to check.Anything else we should know?
No response
Feature ownership
The text was updated successfully, but these errors were encountered: