-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize build fails when resources key is missing #5337
Comments
This issue is currently awaiting triage. SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I spent some time debugging failing builds and the error message for this is sort of misleading. If this regression is intended, feel free to close this issue without fixing, and at least this comment can serve as some documentation that might save someone else some time. |
This is the intended change introduced in v5.1 by PR #4949. This avoids silently ignoring empty files. |
@sarab97: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sarab97 Can I get more clarification on why this does not qualify as a breaking change and a major version increase? |
What happened?
On v5.0,
kustomize build
would build the empty kustomization below .On 5.1.1,
kustomize build
would fail with confusing error message:What did you expect to happen?
I expected 5.1.1 to build the kustomization without errors.
A simple workaround is to define a
resources
key with an empty array as the value.How can we reproduce it (as minimally and precisely as possible)?
Run
kustomize build
on v5.1.1 on the manifestExpected output
No response
Actual output
No response
Kustomize version
5.1.1
Operating system
Linux
The text was updated successfully, but these errors were encountered: