-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README to use 'bases' instead of 'resources' in overlays examples #2255
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @mvbakker! |
Hi @mvbakker. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@mvbakker: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @pwittrock |
I thought
|
@chancez, thanks for the comment, that makes sense. Still when I run
Am I doing something wrong or should I propose a different solution in the PR? |
@mvbakker check out https://github.com/kubernetes-sigs/kustomize#kubectl-integration, which explains the version disparity. Clearly identified versioned docs would go a long way. Of course one could always browse the docs from a specific tag in github, but it's not obvious that one ought to do that. Maybe creating a separate |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mvbakker, pwittrock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry to open this again, I am a bit confused. And in my high-level kustomization I have this:
When I issue
When I update the main kustomization.yaml to this:
and execute If there is any help, this is my kubectl version:
|
@YiannisGkoufas kubectl is using a very old version of Kustomize. It's not strange that the behavior is different. |
ahh thanks @Shell32-Natsu ! is there a way I can test (or check online) the version of kustomize? |
For standalone kustomize you can use |
In kustomize v2
kustomization.yaml
can only refer to files in the same directory as itself, or in subdirectories. Onlybases
can refer to outside paths.Please refer to: #776