Add types and proposal for k8s to kyaml migration. #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
monopole
requested review from
pwittrock
and removed request for
mortent and
phanimarupaka
monopole
changed the title
pwittrock
reviewed
Aug 24, 2020
| "sigs.k8s.io/kustomize/api/resource" | ||
| ) | ||
|
|
||
| // DepProvider is a dependency provider. |
|
So close! This is going to be great when kubectl and use the latest kustomize. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks Phil. I'm pining for a code base built on a decent dependency injection framework. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In service of #1500 and #2506
Purpose of PR is defined in the header comment to api/krusty/internal/provider/depprovider.go
tl/dr: introduce a flag
--enable_kyaml, which when true, switches all remaining code pathsfrom
k8s.io/api*packages tokyamlpackages. The methods on the kyaml side that stillneed implementations are marked with TODO. I think this is an upper-bound on the work.
I'll look into dropping some features to reduce the size of the API surface that needs
implementation (especially the
varsfeature and theReplacementTransformer).