fixStuffDueToKubectlDeletion #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Merged
yanniszark
added a commit
to arrikto/kubernetes-sigs-kustomize
that referenced
this pull request
Apr 13, 2021
Commit 6b99caa79 tried to fix glob handling but broke normal paths. Fix that. GitHub-PR: kubernetes-sigs#3. Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com> Reviewed-by: Dimitris Aragiorgis <dimara@arrikto.com>
13 tasks
annasong20
added a commit
to annasong20/kustomize
that referenced
this pull request
Aug 17, 2022
annasong20
added a commit
to annasong20/kustomize
that referenced
this pull request
Aug 17, 2022
k8s-ci-robot
pushed a commit
that referenced
this pull request
Aug 19, 2022
* Implement file localization for localize Implement file localization for new command kustomize localize * Patch file localization Fix lint errors, address feedback, begin transition to file loader from localizer * Add Repo() to Loader * Implement locLoader factory + cleanup * Add domain to RepoSpec Fix ssh relative url host parsing for non-github domain on the side * Implement Load(), New(), Root(), Dst() for LocLoader * Address repospec code review comments * Address 1st round of code review feedback * Address feedback #2 Removed localized path calculations to cover edge case and improve readability. * Remove ldr Cleanup logging * Address code review round #3 * Address code review feedback #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demos broke when the demo data in the kubectl repo was deleted. Tests WAI, yay