Pin kustomize to api/v0.7.0, enabling kyaml by default #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALLOW_MODULE_SPAN
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
monopole
requested review from
Shell32-Natsu
and removed request for
mengqiy and
phanimarupaka
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In service of #2506
This PR changes the default value of the
kustomize buildflag--enable_kyamlfrom false to true.Going forward from here, the following api branches (if used for new releases) should
only differ in the value of
FlagEnableKyamlDefaultValueFlagEnableKyamlDefaultValue == falseFlagEnableKyamlDefaultValue == trueHopefully we won't have to do more releases in the v0.6 series, but if we do it's a matter
of merging everything in from the main branch but keeping
FlagEnableKyamlDefaultValuefalseALLOW_MODULE_SPAN