-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade json-patch to v5.5.0 #3938
Conversation
Welcome @pacoxu! |
Hi @pacoxu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pacoxu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold let's make sure kubernetes is ready to move to jsonpatch v5 before merging this (there's a compatibility break between v4 and v5 with patch paths lacking a / prefix |
Got it. I will try to learn the context. |
Link the issue here evanphx/json-patch#86. |
Looks like json-patch also released v4.10.0 to make the fix available in the v4 stream. That seems like it might be a better version to switch to (let's verify in kubernetes/kubernetes#102467 (comment) first) |
ack. |
@KnVerey |
As #102467, we upgrade to v4.11.0 because of v5.5.0 has break changes:
|
refer to kubernetes/kubernetes#102467