-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json-patch upgrade to v4.11.0 #3966
json-patch upgrade to v4.11.0 #3966
Conversation
Hi @pacoxu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@pacoxu you can run |
7e23e4c
to
5844c6e
Compare
@natasha41575 Updated, Thanks./ |
5844c6e
to
4fe6e8c
Compare
4fe6e8c
to
21dae54
Compare
Please squash the commits. |
/test |
@monopole: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test kustomize-presubmit-master |
1ba3a6f
to
ab22b53
Compare
Signed-off-by: pacoxu <paco.xu@daocloud.io>
ab22b53
to
24294d3
Compare
squashed @monopole |
@@ -3,6 +3,7 @@ module sigs.k8s.io/kustomize/functions/examples/application-cr | |||
go 1.16 | |||
|
|||
require ( | |||
github.com/evanphx/json-patch v4.11.0+incompatible | |||
k8s.io/apimachinery v0.18.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/go.mod#L10
apimachinery currently requires json-patch v4.11.0.
github.com/evanphx/json-patch v4.2.0+incompatible/go.mod h1:50XU6AFN0ol/bzJsmQLiYLvXMP4fmwYFNcr97nuDLSk=
should be removed once k8s.io/apimachinery upgrade to k/k master version.
/lgtm |
/assign @monopole |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
refer to kubernetes/kubernetes#102467
k/k has upgraded it to v4.11.0.
kyaml/kio/byteio_writer.go change is after I run
hack/kyaml-pre-commit.sh
. I think it is valid.ALLOW_MODULE_SPAN