-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ByteReader to allow white space and comments content after --- when splitting YAML documents #4014
Updated ByteReader to allow white space and comments content after --- when splitting YAML documents #4014
Conversation
22e231a
to
fe17a74
Compare
fe17a74
to
e2a80db
Compare
… after --- and throw an error if anything else is detected
e2a80db
to
78737f5
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Instead of splitting on
\n---\n
, split on\n---.*\n
regular expression.Allow (and discard) any white space or comments, and return an error if other content exists on the same line as
---
Fixes #3876