Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileSystem interface to LocalPackageWriter #4086

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Add FileSystem interface to LocalPackageWriter #4086

merged 4 commits into from
Aug 19, 2021

Conversation

campoy
Copy link
Contributor

@campoy campoy commented Jul 26, 2021

Add a new FileSystem field in kio. LocalPackageWriter for better testing and adapt previous tests to run both using the real file system and an in-memory mock.

Updates #3873

@k8s-ci-robot
Copy link
Contributor

@campoy: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @campoy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 26, 2021
@natasha41575
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2021
@campoy campoy force-pushed the pkgio-writer-filesys branch 4 times, most recently from 0c9304d to c513977 Compare July 27, 2021 00:14
natasha41575
natasha41575 reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, other than that lgtm

/lgtm

kyaml/filesys/fsnode.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2021
KnVerey
KnVerey reviewed Aug 11, 2021
View reviewed changes
kyaml/kio/pkgio_writer.go
if err != nil {
buf.Reset()
w := ByteWriter{
Writer: buf,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than writing to a buffer and then to the fs, would it work to do r.FileSystem.Create(path) and pass the result to the ByteWriter here, more similarly to what was being done before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is that there's no easy way with the current filesystem abstraction to open a file with O_TRUNC

@KnVerey
Copy link
Contributor

KnVerey commented Aug 11, 2021

Can you please rebase when you have a chance? Github isn't flagging it, but the first commit has already merged via your other PR.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
@campoy
Copy link
Contributor Author

campoy commented Aug 19, 2021

After rebasing, this requires a new LGTM

KnVerey
KnVerey approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: campoy, KnVerey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit f604619 into kubernetes-sigs:master Aug 19, 2021
@campoy campoy deleted the pkgio-writer-filesys branch August 20, 2021 16:57
@campoy campoy mentioned this pull request Apr 11, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@KnVerey KnVerey KnVerey approved these changes

@mortent mortent Awaiting requested review from mortent

Assignees

@KnVerey KnVerey

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@campoy @k8s-ci-robot @natasha41575 @KnVerey