-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle parsing of bare sequence yaml nodes #4189
Handle parsing of bare sequence yaml nodes #4189
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phanimarupaka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
792fdff
to
e997cc5
Compare
/cc @KnVerey |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looking good, have a few comments.
Could you provide an example to illustrate in what contexts this is needed? How could a resource be a bare sequence node? |
Here is an example valid YAML node(Kustomization patch) https://github.com/kubeflow/manifests/blob/master/apps/jupyter/notebook-controller/upstream/crd/patches/old_crd.yaml |
Thanks! I still don't quite understand the use case though--the description says "kyaml uses reader annotations to track resources for reading and writing back" and that inability to annotate bare sequence nodes is a problem, but your example is a JSON patch not a resource. What reader annotations do you need to apply to a patch like that? |
kyaml uses reader annotations to track resources for reading and writing back, it is not possible to add reader annotations to bare sequence nodes, this PR introduces a way to wrap/unwrap such nodes for smooth yaml processing.