-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cobra for better zsh support #4310
Conversation
Hi @sylr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
29118e5
to
5e5f7bd
Compare
@natasha41575 could you merge this please ? |
/ok-to-test |
I was initially very wary of all the new dependencies this pulls in, but I see that kubectl has already merged the same upgrade (and indeed already had most of the dependencies in question from other sources before the upgrade): kubernetes/kubernetes#103448. PR needs rebase before LGTM. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, sylr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
@KnVerey rebased |
/lgtm |
kustomize build ...
does not complete file paths on ZSH.It will with this upgrade.