Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate enable-managedby-label flag in favor of a field #4377

Merged
merged 1 commit into from
Jan 20, 2022
Merged

deprecate enable-managedby-label flag in favor of a field #4377

merged 1 commit into from
Jan 20, 2022

Conversation

natasha41575
Copy link
Contributor

This deprecates the flag enable-managedby-label and replaces it with an option managedByLabel in the buildMetadata field. As discussed previously, we would like to move flags like this to fields as we prepare for kustomize v5 and kustomization v1.

Fixes #4047

/cc @yuwenma
/cc @KnVerey

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@natasha41575 natasha41575 force-pushed the managedBy branch 3 times, most recently from d800840 to cfeeff4 Compare January 11, 2022 00:29
@yuwenma
Copy link
Contributor

yuwenma commented Jan 19, 2022

lgtm. A minor comment for test style.

@yuwenma
Copy link
Contributor

yuwenma commented Jan 20, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6e5d267 into kubernetes-sigs:master Jan 20, 2022
@natasha41575 natasha41575 deleted the managedBy branch August 31, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey Awaiting requested review from KnVerey

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@yuwenma yuwenma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider deprecating the --enable-managedby-label in favor of a field
3 participants
@natasha41575 @k8s-ci-robot @yuwenma