Fix regression 4388 #4445
Merged
Fix regression 4388 #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
KnVerey
force-pushed
the
ordering_regression_4388
branch
2 times, most recently
from
9b98956
to
ce35e4c
Compare
KnVerey
force-pushed
the
ordering_regression_4388
branch
from
ce35e4c
to
a86723c
Compare
KnVerey
commented
Feb 2, 2022
| {Gvk{Group: "b", Version: "c", Kind: "Namespace"}, | ||
| Gvk{Group: "a", Version: "d", Kind: "Namespace"}}, | ||
| {Gvk{Group: "a", Version: "d", Kind: "Namespace"}, | ||
| Gvk{Group: "b", Version: "c", Kind: "Namespace"}}, |
There was a problem hiding this comment.
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Sorry I accidentally hit close with comment instead of comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4388
This should have been release-blocking, and we should re-release today with this patch.
/cc @natasha41575