add MakeHashTransformer in TransformerFactory; remove hash interface #451
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Liujingfang1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/L
| ) | ||
|
|
||
| // patchTransformerFactory makes patch transformer | ||
| type transformerFactoryImpl struct{} |
There was a problem hiding this comment.
since we're in transformer package, don't need to use "transformer" - just factoryImpl.
Also, fix comment.
pkg/ifc/transformer/transformer.go
Outdated
| @@ -25,4 +25,5 @@ import ( | |||
| // TransformerFactory makes patch transformer. | |||
| type TransformerFactory interface { | |||
There was a problem hiding this comment.
ditto, if you want to put this a 'transformer' package, don't need Transformer in the class name - just call it Factory
FWIW, the transformerconfig package is slightly odd with its naming.
if desired, you could try moving it to pkg/transformer/config then shorten the object names in a different PR.
k8s-ci-robot
added
the
lgtm
No description provided.