Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install goreleaser into go 1.18 image for build #4571

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

KnVerey
Copy link
Contributor

@KnVerey KnVerey commented Apr 6, 2022

Closes #4523

We still need to stick with goreleaser v0.179.0 because of #4542, but that doesn't inherently stop us from building with a newer Go version. This PR takes the approach of manually installing the correct version into the official Go container (instead of the other way around as in my previous attempt).

Note: I did not use alpine because it doesn't have bash, and our scripts are written for bash. This didn't actually cause problems so far, but I think this choice is more maintainable and future-proof.

I tested this as described in releasing/cloudbuild.sh, which should be representative since only one container is involved in this solution. But it would still be great if you could test it with cloud-build-local (which still isn't available to me). 🙏

/cc @natasha41575

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2022
@natasha41575
Copy link
Contributor

I tested this as described in releasing/cloudbuild.sh, which should be representative since only one container is involved in this solution. But it would still be great if you could test it with cloud-build-local (which still isn't available to me).

👍 Ran it locally, everything succeeded until the key decryption step as expected.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KnVerey,natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0989b26 into kubernetes-sigs:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerable golang version used for packaging (multiple critical and high CVEs)
3 participants