-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve invalid node kind errors #4727
Improve invalid node kind errors #4727
Conversation
e129139
to
7a38a5f
Compare
@KnVerey: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold for rebase on #4704 when it merges (unless we change our mind about the order) |
7a38a5f
to
ffdb1ed
Compare
✅ Deploy Preview for kubernetes-sigs-kustomize canceled.
|
This has been rebased, but it might be good to hold until after the next release in case the dep upgrade unexpectedly is in fact an issue for kubectl. |
ffdb1ed
to
873d0b2
Compare
/unhold This is ready for a look |
Ah sorry I missed this PR /lgtm I can retag if you need to rebase |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ldspecs Also remove invalid+ignored fieldspecs from the defaults
873d0b2
to
f8d1e77
Compare
@natasha41575 I rebased and added two new commits: one making an improvement I couldn't do in #4754 because of the go-errors version, and another committing go.sum changes. PTAL. |
/lgtm |
The format was changed in upstream kyaml/fn version in kubernetes-sigs/kustomize#4727.
The format was changed in upstream kyaml/fn version in kubernetes-sigs/kustomize#4727. Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
* Fix failing fn-eval test The format was changed in upstream kyaml/fn version in kubernetes-sigs/kustomize#4727. Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com> * Run git diff without options in tests I had issues running tests since it was using my custom settings for `git diff`, resulting in mismatch when evaluating diffs. I also had to prefix my commands with `env DOCKER_DEFAULT_PLATFORM=linux/amd64` because I'm on Apple Silicon. Otherwise, the warning output for platform mismatch also resulted in false negatives. Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com> * Remove porch go.* files Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com> --------- Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
Also enhance this kind of error specifically in the namespace transformer, explaining to the user that it is probably a field spec issue. Also remove ignored field specs from that transformer's defaults, including two that are invalid in a way that would produce this message (but continuing to ignore the valid path).
@annasong20 was correct that it is the kyaml error package that is not working with
errors.Is
anderrors.As
. That is because it uses a very old version of its go-errors dependency, that didn't have go-1.13 style support. I think we are the reason k/k has this dep, and the diff to update all the way to latest is quite small in any case: go-errors/errors@v1.0.1...v1.4.2./cc @natasha41575