feat: add remove configmap command #4796

yufeiminds · 2022-09-15T13:12:31Z

If someone need update the file list of the configMapGenerator from directory, they can use add configmap and remove configmap together.

Like this:

# Initialize
kustomize edit add configmap routes-01 --from-file="folder1/conf.d/*"
kustomize edit add configmap routes-02 --from-file="folder2/conf.d/*"

# Refresh configmap
kustomize edit remove configmap routes-01,routes-02
kustomize edit add configmap routes-01 --from-file="folder1/conf.d/*"
kustomize edit add configmap routes-01 --from-file="folder1/conf.d/*"

#4493

linux-foundation-easycla · 2022-09-15T13:12:36Z

The committers listed above are authorized under a signed CLA.

✅ login: yufeiminds / name: Yufei Li (0d7c56d)

k8s-ci-robot · 2022-09-15T13:12:40Z

Welcome @yufeiminds!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-09-15T13:12:41Z

Hi @yufeiminds. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

natasha41575 · 2022-10-14T17:25:12Z

@koba1t could you please do a quick review of this PR?

koba1t

Hi, @yufeiminds
Thanks for your contribution!!
I add a few comments for your code.
Could you check there?

kustomize/commands/edit/remove/configmap_test.go

k8s-ci-robot · 2022-10-31T11:13:09Z

@yufeiminds: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yufeiminds · 2022-10-31T11:14:19Z

/label tide/merge-method-squash

yufeiminds · 2022-10-31T11:18:45Z

Yet another question, should we create a new pull request to support removing secrets? Because they are brothers. 😄

koba1t · 2022-10-31T14:15:54Z

/ok-to-test

koba1t · 2022-10-31T15:41:44Z

/lgtm

hi @natasha41575
This PR looks good to me, Could you exec tests and lint on GitHub actions?

natasha41575 · 2022-11-16T16:12:14Z

This PR looks good to me, Could you exec tests and lint on GitHub actions?

Thanks for the review, and sorry for the delay! Running the tests now.

yufeiminds · 2022-11-24T13:37:47Z

Hi, @koba1t

I have fixed the lint issues, there is an issue with testpackage linter. It will conflict with the remove_test package. So I create a nolint comment to ignore it. It may not affect the feature and code smell. If we need to fix it after that. I can create another pull request to fix all the commands of remove/remove_test package.

And @natasha41575, Could you exec tests and lint on GitHub actions again? Thank you~ 😄

koba1t · 2022-11-25T13:03:20Z

It will conflict with the remove_test package.

Sorry, I didn't know that package already existed, and I think that it needs to clean up...
nolint:testpackage is used here and I think it permitted.

So, I think your fix is good. Thanks for your fix!
/lgtm

yufeiminds · 2022-12-28T03:01:02Z

@natasha41575 hi, any feedback about this PR?

kustomize/commands/edit/remove/removeconfigmap.go

yufeiminds · 2023-01-12T13:20:51Z

Hi, @natasha41575, @koba1t. I resolved the conversations. Please push it forward again. Thank you~

yufeiminds · 2023-02-08T02:53:28Z

@koba1t Hi, can you review it and push it forward? Thank you. 🍻

koba1t · 2023-02-14T11:50:50Z

/lgtm
Thank you!

yufeiminds · 2023-05-10T08:36:08Z

@natasha41575 Hi, does this PR and #4872 could be merged?

I used my own modified version in our pipeline before it was merged. I am looking forward to it being integrated into the mainline as soon as possible. If any problems arise, please feel free to reach out to me. 😊

stormqueen1990

LGTM! Just leaving a minor suggestion for the error message.

/lgtm

stormqueen1990 · 2023-08-27T22:54:58Z

kustomize/commands/edit/remove/removeconfigmap.go

+	m.ConfigMapGenerator = newConfigMaps
+	err = mf.Write(m)
+	if err != nil {
+		return fmt.Errorf("configmap cannot write back to file, got %w", err)


Minor suggestion:

Suggested change

return fmt.Errorf("configmap cannot write back to file, got %w", err)

return fmt.Errorf("failed to write kustomization file: %w", err)

k8s-ci-robot · 2023-08-29T02:05:33Z

@stormqueen1990: changing LGTM is restricted to collaborators

In response to this:

LGTM! Just leaving a minor suggestion for the error message.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stormqueen1990 · 2023-08-30T21:51:22Z

/lgtm

natasha41575 · 2023-09-01T15:11:39Z

kustomize/commands/edit/remove/removeconfigmap.go

+	cmd := &cobra.Command{
+		Use: "configmap",
+		Short: "Removes specified configmap" +
+			konfig.DefaultKustomizationFileName(),


This should say Removes specified configmap from kustomization.yaml

It currently reads as Removes specified configmapkustomization.yaml

k8s-ci-robot · 2023-09-01T15:18:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, yufeiminds

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

natasha41575 · 2023-09-01T15:19:38Z

@yufeiminds The tests aren't triggering, I think because you created the PR before the tests ran. Can you push a commit address #4796 (comment)? I think that will trigger the tests.

k8s-ci-robot · 2023-09-01T15:26:21Z

@yufeiminds: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kustomize-presubmit-master	`927804d`	link	unknown	`/test kustomize-presubmit-master`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

natasha41575 · 2023-09-01T15:28:32Z

kustomize/commands/edit/remove/removeconfigmap.go

+	"github.com/spf13/cobra"
+	"sigs.k8s.io/kustomize/api/konfig"
+	"sigs.k8s.io/kustomize/api/types"
+	"sigs.k8s.io/kustomize/kustomize/v4/commands/internal/kustfile"


This will need to change to v5

stormqueen1990 · 2023-09-13T00:23:14Z

Closing this in favour of #5327

/close

k8s-ci-robot · 2023-09-13T00:23:18Z

@stormqueen1990: Closed this PR.

In response to this:

Closing this in favour of #5327

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feat: add remove configmap command

0d7c56d

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 15, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 15, 2022

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2022

k8s-ci-robot requested review from KnVerey and yuwenma September 15, 2022 13:12

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 15, 2022

yufeiminds mentioned this pull request Sep 15, 2022

Support edit set configmap #4493

Closed

natasha41575 requested a review from koba1t October 14, 2022 17:25

koba1t reviewed Oct 19, 2022

View reviewed changes

kustomize/commands/edit/remove/configmap_test.go Outdated Show resolved Hide resolved

kustomize/commands/edit/remove/configmap_test.go Outdated Show resolved Hide resolved

fix: add logging when configmap not exists

0235f10

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 31, 2022

yufeiminds requested review from koba1t and removed request for KnVerey and yuwenma October 31, 2022 11:15

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2022

k8s-ci-robot assigned koba1t Oct 31, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2022

fix: correct lint issues

8ca1f38

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2022

natasha41575 reviewed Jan 6, 2023

View reviewed changes

natasha41575 added this to the v5.0.0 milestone Jan 6, 2023

fix: Resolve conversation

927804d

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023

natasha41575 removed this from the v5.0.0 milestone Jan 31, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023

stormqueen1990 reviewed Aug 29, 2023

View reviewed changes

k8s-ci-robot assigned stormqueen1990 Aug 30, 2023

natasha41575 approved these changes Sep 1, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023

natasha41575 reviewed Sep 1, 2023

View reviewed changes

stormqueen1990 mentioned this pull request Sep 13, 2023

feat: add remove configmap command #5327

Merged

k8s-ci-robot closed this Sep 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add remove configmap command #4796

feat: add remove configmap command #4796

yufeiminds commented Sep 15, 2022 •

edited by natasha41575

Loading

linux-foundation-easycla bot commented Sep 15, 2022 •

edited

Loading

k8s-ci-robot commented Sep 15, 2022

k8s-ci-robot commented Sep 15, 2022

natasha41575 commented Oct 14, 2022

koba1t left a comment •

edited

Loading

k8s-ci-robot commented Oct 31, 2022

yufeiminds commented Oct 31, 2022

yufeiminds commented Oct 31, 2022 •

edited

Loading

koba1t commented Oct 31, 2022

koba1t commented Oct 31, 2022

natasha41575 commented Nov 16, 2022

yufeiminds commented Nov 24, 2022

koba1t commented Nov 25, 2022 •

edited

Loading

yufeiminds commented Dec 28, 2022

yufeiminds commented Jan 12, 2023

yufeiminds commented Feb 8, 2023

koba1t commented Feb 14, 2023 •

edited

Loading

yufeiminds commented May 10, 2023

stormqueen1990 left a comment

stormqueen1990 Aug 27, 2023

k8s-ci-robot commented Aug 29, 2023

stormqueen1990 commented Aug 30, 2023

natasha41575 Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

natasha41575 commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

natasha41575 Sep 1, 2023

stormqueen1990 commented Sep 13, 2023

k8s-ci-robot commented Sep 13, 2023

	return fmt.Errorf("configmap cannot write back to file, got %w", err)
	return fmt.Errorf("failed to write kustomization file: %w", err)

feat: add remove configmap command #4796

feat: add remove configmap command #4796

Conversation

yufeiminds commented Sep 15, 2022 • edited by natasha41575 Loading

linux-foundation-easycla bot commented Sep 15, 2022 • edited Loading

k8s-ci-robot commented Sep 15, 2022

k8s-ci-robot commented Sep 15, 2022

natasha41575 commented Oct 14, 2022

koba1t left a comment • edited Loading

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 31, 2022

yufeiminds commented Oct 31, 2022

yufeiminds commented Oct 31, 2022 • edited Loading

koba1t commented Oct 31, 2022

koba1t commented Oct 31, 2022

natasha41575 commented Nov 16, 2022

yufeiminds commented Nov 24, 2022

koba1t commented Nov 25, 2022 • edited Loading

yufeiminds commented Dec 28, 2022

yufeiminds commented Jan 12, 2023

yufeiminds commented Feb 8, 2023

koba1t commented Feb 14, 2023 • edited Loading

yufeiminds commented May 10, 2023

stormqueen1990 left a comment

Choose a reason for hiding this comment

stormqueen1990 Aug 27, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 29, 2023

stormqueen1990 commented Aug 30, 2023

natasha41575 Sep 1, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 1, 2023

natasha41575 commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

natasha41575 Sep 1, 2023

Choose a reason for hiding this comment

stormqueen1990 commented Sep 13, 2023

k8s-ci-robot commented Sep 13, 2023

yufeiminds commented Sep 15, 2022 •

edited by natasha41575

Loading

linux-foundation-easycla bot commented Sep 15, 2022 •

edited

Loading

koba1t left a comment •

edited

Loading

yufeiminds commented Oct 31, 2022 •

edited

Loading

koba1t commented Nov 25, 2022 •

edited

Loading

koba1t commented Feb 14, 2023 •

edited

Loading