Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RepoSpec parseHostSpec #4932

Closed
wants to merge 1 commit into from
Closed

Refactor RepoSpec parseHostSpec #4932

wants to merge 1 commit into from

Conversation

annasong20
Copy link
Contributor

This PR fixes #4847. This PR also attempts to increase the readability of parseHostSpec to increase maintainability and reduce the likelihood of such bugs occurring in the future.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: annasong20
Once this PR has been reviewed and has the lgtm label, please assign natasha41575 for approval by writing /assign @natasha41575 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 15, 2022
annasong20
annasong20 commented Dec 15, 2022
View reviewed changes
api/internal/git/repospec_test.go
@@ -191,24 +195,37 @@ func TestNewRepoSpecFromUrl_Smoke(t *testing.T) {
},
{
name: "t6",
input: "git@gitlab2.sqtools.ru:10022/infra/kubernetes/thanos-base.git?ref=v0.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was invalid. git fetch would've treated 10022 as a folder name, not a port.

@annasong20
Refactor parseHostSpec
0e0268d 
Fix ssh parsing in issue 4847
@annasong20
Copy link
Contributor Author

/cc @KnVerey

@KnVerey KnVerey mentioned this pull request Jan 4, 2023
Merged
@k8s-ci-robot
Copy link
Contributor

@annasong20: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2023
@annasong20 annasong20 closed this Jan 10, 2023
@annasong20 annasong20 deleted the refactor-host branch January 12, 2023 18:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba1t koba1t Awaiting requested review from koba1t

@yuwenma yuwenma Awaiting requested review from yuwenma

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RepoSpec parses non-github ssh urls incorrectly
2 participants
@annasong20 @k8s-ci-robot