Localize HelmChartInflationGenerator #5007
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
| const readmeErr = `mapping values are not allowed in this context` | ||
| fileErr := fmt.Sprintf(`invalid resource at file "%s": MalformedYAMLError:`, repo) | ||
| fileErr := fmt.Sprintf(`invalid resource at file "%s": MalformedYAMLError`, repo) | ||
| rootErr := fmt.Sprintf(`unable to localize root "%s": unable to find one of 'kustomization.yaml', 'kustomization.yml' or 'Kustomization'`, repo) | ||
| var actualErr PathLocalizeError | ||
| require.ErrorAs(t, err, &actualErr) | ||
| require.Equal(t, repo, actualErr.Path) | ||
| require.ErrorContains(t, actualErr.FileError, readmeErr) | ||
| require.ErrorContains(t, actualErr.FileError, fileErr) | ||
| require.ErrorContains(t, actualErr.RootError, rootErr) |
There was a problem hiding this comment.
I removed the readmeErr that's specific to the contents of the kustomize repo README.md and irrelevant to our test, which just expects that the README is invalid yaml.
The over-specificity of this test previously failed the ci pipeline on master: https://github.com/kubernetes-sigs/kustomize/actions/runs/4018832421/jobs/6904935339
| func TestLocalizeGeneratorsHelm(t *testing.T) { | ||
| files := map[string]string{ | ||
| "kustomization.yaml": `generators: | ||
| - default.yaml |
There was a problem hiding this comment.
Does localize currently handle generators defined inline? This is not required for alpha imo, but if it already handled, can we add a test? If not, can we add a TODO?
Adding an example in case it's unclear what I'm referring to:
generators:
- |-
apiVersion: builtin
kind: HelmChartInflationGenerator
...
There was a problem hiding this comment.
Done. Yes, we handle inline generators and I added a test.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annasong20, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
size/L
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
This PR localizes the
HelmChartInflationGeneratorcustom transformer. If chart home isn't specified, the default home is copied.