-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to json-patch v5 #5197
Switch to json-patch v5 #5197
Conversation
Welcome @skitt! |
Hi @skitt. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hi @skitt I found two modified: cmd/pluginator/go.sum
modified: plugin/builtin/iampolicygenerator/go.sum Could you try exec for |
Done, thanks for the tip! |
No problem! Thanks for your update! |
/lgtm |
/test all |
/lgtm |
json-patch was bumped to v5 in k/k as a result of kubernetes/kubernetes#118384; this aligns with that, but switches to the v5 module, which is documented as gopkg.in/evanphx/json-patch.v5. Signed-off-by: Stephen Kitt <skitt@redhat.com>
I’ll close and re-open this to see if that triggers the tests. |
@skitt The closing and re-opening did it! The tests are now running. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annasong20, skitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
json-patch was bumped to v5 in k/k as a result of
kubernetes/kubernetes#118384; this aligns with that, but switches to the v5 module, which is documented as gopkg.in/evanphx/json-patch.v5.