-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gopkg.in/yaml.v2 with sigs.k8s.io/yaml/goyaml.v2 #5421
Replace gopkg.in/yaml.v2 with sigs.k8s.io/yaml/goyaml.v2 #5421
Conversation
Welcome @prashantrewar! |
Hi @prashantrewar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, but I think this needs a go work sync
. I see an extra change when doing so locally after applying the changes from this PR.
Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
f842522
to
2ab1171
Compare
Thanks @stormqueen1990, I have made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for the contribution! Please feel free to check out the kustomize project boards if you are interested in contributing to more open issues.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, prashantrewar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #5419