Sort built-in Namespace kind before CRDs with the same name #5458

danielwilsonkainos · 2023-11-20T16:31:42Z

Adds differentiation and correct priority between ASO ServiceBus Namespace kind and core Kubernetes Namespace kind when sorting kustomize build output file. (core Kubernetes Namespace higher than ASO Namespace)

k8s-ci-robot · 2023-11-20T16:31:44Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

linux-foundation-easycla · 2023-11-20T16:31:48Z

The committers listed above are authorized under a signed CLA.

✅ login: danielwilsonkainos / name: Daniel Wilson (cc96884, ad5ca54, ad620e8, cf07bd9, 2beab4c, 149aad5, a0985b1)

k8s-ci-robot · 2023-11-20T16:31:52Z

Hi @danielwilsonkainos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danielwilsonkainos · 2023-11-20T16:35:22Z

For issue #5457

ncapps

@danielwilsonkainos Thank you for contributing this fix. I created #5490 to further improve this enhancement to sort all builtins before CRDS.

/lgtm

k8s-triage-robot · 2024-03-12T18:36:41Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

stormqueen1990 · 2024-03-30T23:10:06Z

plugin/builtin/sortordertransformer/SortOrderTransformer_test.go

Is the group name in these tests significant? If not, could we use something more generic (such as group.example.org/v1)?

Same for the namespace name (most resources use fruit names, it would be nice to keep that consistent).

stormqueen1990 · 2024-03-30T23:11:12Z

/remove-lifecycle stale
/retitle Sort built-in Namespace kind before CRDs with the same name
/retest

stormqueen1990 · 2024-03-30T23:11:57Z

/assign @koba1t
for maintainer review

stormqueen1990 · 2024-03-30T23:58:20Z

/ok-to-test

stormqueen1990 · 2024-03-31T00:01:56Z

@danielwilsonkainos could you please try rebasing this branch?

k8s-triage-robot · 2024-06-29T00:14:30Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-07-29T00:15:37Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

koba1t · 2024-08-06T19:49:56Z

HI @danielwilsonkainos
Could you try rebase master?

danielwilsonkainos · 2024-08-07T08:51:48Z

@koba1t sorry to go dead on this - have rebased

koba1t · 2024-08-07T10:53:49Z

Hi @danielwilsonkainos
Could you try make generate-kustomize-builtin-plugins that regenerate builtin plugins?

kustomize/Makefile-plugins.mk

Line 94 in cc9dd34

generate-kustomize-builtin-plugins: $(builtplugins)

I believe that will fix CI problems.

danielwilsonkainos · 2024-08-08T14:43:12Z

regenerated 🙂

koba1t · 2024-09-03T20:42:38Z

/label tide/merge-method-squash

koba1t · 2024-09-03T20:43:22Z

Thanks @danielwilsonkainos
/lgtm
/approve

k8s-ci-robot · 2024-09-03T20:43:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielwilsonkainos, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.4.3` -> `v5.5.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary> ### [`v5.5.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.5.0) [Compare Source](kubernetes-sigs/kustomize@kustomize/v5.4.3...kustomize/v5.5.0) ### Breaking change A starlark support for krm functions was removed to cleanup dependencies. kubernetes-sigs/kustomize#5768 This feature was deprecated 3 years ago and removed because there was no desire to continue using it. kubernetes-sigs/kustomize#5768 (comment) #### Feature [#5751](kubernetes-sigs/kustomize#5751): Add `--helm-debug` Flag to Kustomize for Enhanced Helm Debugging #### Fix Bugs [#5458](kubernetes-sigs/kustomize#5458): Sort built-in Namespace kind before CRDs with the same name [#5745](kubernetes-sigs/kustomize#5745): Add Annotation to Control Inline List Conversion in Kustomize Resources" #### Dependencies [#5763](kubernetes-sigs/kustomize#5763): Update go 1.22.7 [#5781](kubernetes-sigs/kustomize#5781): Update kyaml to v0.18.1 [#5782](kubernetes-sigs/kustomize#5782): Update cmd/config to v0.15.0 [#5783](kubernetes-sigs/kustomize#5783): Update api to v0.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

danielwilsonkainos added 5 commits November 15, 2023 10:05

add core api sort priority for NAmespace kind in gvkLessThan

ad5ca54

fix logic

cc96884

fix syntax

a0985b1

fix syntax

149aad5

fix logic

2beab4c

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 20, 2023

k8s-ci-robot requested a review from natasha41575 November 20, 2023 16:31

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 20, 2023

k8s-ci-robot requested a review from yuwenma November 20, 2023 16:31

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 20, 2023

danielwilsonkainos mentioned this pull request Nov 20, 2023

Kustomise build order gives higher priority to ASO ServiceBus Namespace kind above Kubernetes core API Namespace kind #5457

Open

ncapps reviewed Dec 13, 2023

View reviewed changes

k8s-ci-robot assigned ncapps Dec 13, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2024

stormqueen1990 reviewed Mar 30, 2024

View reviewed changes

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 30, 2024

k8s-ci-robot changed the title ~~Differentiate Namespace Kinds in SortOrderTransformer to allow for Azure ServiceBus Namespaces~~ Sort built-in Namespace kind before CRDs with the same name Mar 30, 2024

k8s-ci-robot assigned koba1t Mar 30, 2024

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 30, 2024

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 30, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 29, 2024

koba1t closed this Aug 6, 2024

koba1t reopened this Aug 6, 2024

Merge branch 'kubernetes-sigs:master' into sortorder

ad620e8

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2024

regenerate builtin plugins

cf07bd9

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2024

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 3, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024

k8s-ci-robot merged commit b7cdd91 into kubernetes-sigs:master Sep 3, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sort built-in Namespace kind before CRDs with the same name #5458

Sort built-in Namespace kind before CRDs with the same name #5458

danielwilsonkainos commented Nov 20, 2023

k8s-ci-robot commented Nov 20, 2023

linux-foundation-easycla bot commented Nov 20, 2023 •

edited

Loading

k8s-ci-robot commented Nov 20, 2023

danielwilsonkainos commented Nov 20, 2023

ncapps left a comment

k8s-triage-robot commented Mar 12, 2024

stormqueen1990 Mar 30, 2024 •

edited

Loading

stormqueen1990 commented Mar 30, 2024

stormqueen1990 commented Mar 30, 2024

stormqueen1990 commented Mar 30, 2024

stormqueen1990 commented Mar 31, 2024

k8s-triage-robot commented Jun 29, 2024

k8s-triage-robot commented Jul 29, 2024

koba1t commented Aug 6, 2024

danielwilsonkainos commented Aug 7, 2024

koba1t commented Aug 7, 2024 •

edited

Loading

danielwilsonkainos commented Aug 8, 2024

koba1t commented Sep 3, 2024

koba1t commented Sep 3, 2024

k8s-ci-robot commented Sep 3, 2024

Sort built-in Namespace kind before CRDs with the same name #5458

Sort built-in Namespace kind before CRDs with the same name #5458

Conversation

danielwilsonkainos commented Nov 20, 2023

k8s-ci-robot commented Nov 20, 2023

linux-foundation-easycla bot commented Nov 20, 2023 • edited Loading

k8s-ci-robot commented Nov 20, 2023

danielwilsonkainos commented Nov 20, 2023

ncapps left a comment

Choose a reason for hiding this comment

k8s-triage-robot commented Mar 12, 2024

stormqueen1990 Mar 30, 2024 • edited Loading

Choose a reason for hiding this comment

stormqueen1990 commented Mar 30, 2024

stormqueen1990 commented Mar 30, 2024

stormqueen1990 commented Mar 30, 2024

stormqueen1990 commented Mar 31, 2024

k8s-triage-robot commented Jun 29, 2024

k8s-triage-robot commented Jul 29, 2024

koba1t commented Aug 6, 2024

danielwilsonkainos commented Aug 7, 2024

koba1t commented Aug 7, 2024 • edited Loading

danielwilsonkainos commented Aug 8, 2024

koba1t commented Sep 3, 2024

koba1t commented Sep 3, 2024

k8s-ci-robot commented Sep 3, 2024

linux-foundation-easycla bot commented Nov 20, 2023 •

edited

Loading

stormqueen1990 Mar 30, 2024 •

edited

Loading

koba1t commented Aug 7, 2024 •

edited

Loading