Add buildMetadata task and ref #5511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
ncapps
force-pushed
the
docs/ref/kustomization
branch
2 times, most recently
from
374ba0d
to
ad1d98b
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
There was a problem hiding this comment.
This is looking good! I just have a few questions about abbreviations throughout the doc.
Another question is whether it would be good to change the format of the buildMetadata field to follow the more standardized YAML list, i.e.
buildMetadata:
- originAnnotations
- managedByLabelWhile the original content did use the bracket notation, I think mixing up notations is looking a little odd. WDYT?
Comment on lines
63
to
64
| - `ref`: If from a remote file or generator, the ref of the repo URL. | ||
| - `repo`: If from a remote file or generator, the repo source. |
There was a problem hiding this comment.
Is it worth expanding "ref" to "reference" and "repo" to "repository" here, instead of using the abbreviated forms?
I tend to avoid using abbreviated forms whenever possible to avoid confusion on the reader side, but I'm not super familiar with the context here to judge whether one is better than the other.
There was a problem hiding this comment.
Sounds good. I removed the abbreviations from the descriptions of the fields.
Comment on lines
65
to
67
| - `configuredIn`: If a generated resource, the path to the generator config. If a generator is invoked via a field | ||
| in the kustomization file, this would point to the kustomization file itself. | ||
| - `configuredBy`: If a generated resource, the ObjectReference of the generator config. |
There was a problem hiding this comment.
Suggested change
| - `configuredIn`: If a generated resource, the path to the generator config. If a generator is invoked via a field | |
| in the kustomization file, this would point to the kustomization file itself. | |
| - `configuredBy`: If a generated resource, the ObjectReference of the generator config. | |
| - `configuredIn`: for generated resources, the path to the generator config. If a generator is invoked via a field | |
| in the kustomization file, this would point to the kustomization file itself. | |
| - `configuredBy`: for generated resources, the ObjectReference of the generator config. |
Same question for "config" here (although I reckon that "config" is a fairly standardized term).
There was a problem hiding this comment.
Same as above. I removed the abbreviations and reworded the descriptions.
Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example
ncapps
force-pushed
the
docs/ref/kustomization
branch
from
ad1d98b
to
bdd686c
Compare
|
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
approved
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
/remove-approve |
k8s-ci-robot
removed
the
approved
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncapps The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Feb 3, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Feb 4, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Feb 13, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Feb 21, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Feb 21, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Feb 21, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Feb 21, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Mar 17, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Mar 24, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Mar 24, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
Apr 22, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
antoooks
pushed a commit
to antoooks/kustomize
that referenced
this pull request
May 12, 2024
* Add buildMetadata task and ref Move build metadata tasks, draft buildMetadata reference Clean up buildMetadata ref Add managed by label task Add local non-generated task Add local generated resource Add remote generator task Clean up tasks and ref Add local transformer annotation example Add local and remote transformer example * Address PR feedback and general cleanup cherrypick updates from feature branch fix script fix release script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5379 #5286 #5352
This change adds tasks that demonstrate how to use the
buildMetadatafield.